-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSS Requrements, CI configuration #6
Conversation
0exp
commented
May 25, 2019
•
edited
Loading
edited
- actualized license years
- OSS mail contact
- travis recofnigration
- rubocop development dependency
- bin/console utility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
.rubocop.yml
Outdated
@@ -3,7 +3,7 @@ inherit_gem: | |||
|
|||
AllCops: | |||
DisplayCopNames: true | |||
TargetRubyVersion: 2.5 | |||
TargetRubyVersion: 2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that target rubocop version should be the minimum supported version of MRI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the travis build.
.rubocop.yml
Outdated
@@ -3,7 +3,7 @@ inherit_gem: | |||
|
|||
AllCops: | |||
DisplayCopNames: true | |||
TargetRubyVersion: 2.5 | |||
TargetRubyVersion: 2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1