Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider multiple buckets support #102

Closed
victorskl opened this issue Jun 21, 2022 · 1 comment · Fixed by #126
Closed

Consider multiple buckets support #102

victorskl opened this issue Jun 21, 2022 · 1 comment · Fixed by #126
Assignees
Labels
enhancement New feature or request
Projects

Comments

@victorskl
Copy link
Member

Context:

export HTSGET_S3_BUCKET=my-primary-data

Desirable:

  • It would be good; if we can configure it to multiple buckets as data may sparsely located across multiple locations/buckets

Related:

  • This may also related to Htsget REST API endpoint resource ID mapping; currently is with regex pattern .* matching all keys under a bucket
  • Hence, in-turn, this request indirectly refer to consider include bucket as part of its REST endpoint resource ID mapping
  • i.e.
s3://my-bucket1/subject/key/to/data1.bam
s3://my-bucket2/another/subject/key/to/data1.bam

Then, Htsget REST endpoint resource ID will become

https://htsget-rs.my.org/my-bucket1/subject/key/to/data1.bam
https://htsget-rs.my.org/my-bucket2/another/subject/key/to/data1.bam

(or without extension suffix is fine)
https://htsget-rs.my.org/my-bucket1/subject/key/to/data1
https://htsget-rs.my.org/my-bucket2/another/subject/key/to/data1

Or, with htsget URI scheme (on-going discussion #581 umccr/data-portal-client#88)

htsget://data.my.org/my-bucket1/subject/key/to/data1
htsget://data.my.org/my-bucket2/another/subject/key/to/data1
@brainstorm
Copy link
Member

brainstorm commented Jun 21, 2022

Thanks for opening this one, Victor, it taps into a related discussion in #88 (comment). If we implement the multi-storage backend feature we should also support multiple data sources from within the same storage backend, transparently.

/cc @mmalenic

@brainstorm brainstorm added the enhancement New feature or request label Jun 30, 2022
@brainstorm brainstorm added this to To do in 1.0.0 Dec 16, 2022
@brainstorm brainstorm moved this from To do to In progress in 1.0.0 Dec 16, 2022
1.0.0 automation moved this from In progress to Done Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
1.0.0
Done
Development

Successfully merging a pull request may close this issue.

3 participants