direct htsget + typescript #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added typescript support Converted IGV.js to typescript
|
I possibly need to deploy this to dev - to give it a good test deployed. Whilst I was deploying it locally - it wasn't able to test all the regression features. |
victorskl
approved these changes
Jan 13, 2022
src/containers/IGV.tsx
Outdated
| return; | ||
| } | ||
|
|
||
| // the htsget url scheme is actually unofficial - IGV itself needs to be passed a Https endpoint from |
There was a problem hiding this comment.
the htsget url scheme is actually unofficial
Oh yeah; let tag relevant upstream issue -- samtools/hts-specs#581 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to load htsget:// tracks directly
Added typescript support
Converted IGV.js to typescript