Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: refactor tests to avoid a circular dependency with htsget-search and htsget-http #160

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Feb 22, 2023

Closes #158

This PR refactors htsget-tests to avoid a circular dependency with htsget-search and htsget-http.

Implementation

  • Use generic types in http-tests to avoid using the structs in htsget-search and htsget-http.
  • Specify expected responses using serde_json Value. This also probably makes the tests more robust as they no longer dependent on the implementation of the htsget-http structs.
  • Move CertificateKeyPair to config to avoid repeating the logic in htsget-tests and simplifying logic in htsget-search. This is a breaking change as it removes the TryFrom<DataServerConfig> for HttpTicketFormatter implementation.

@brainstorm brainstorm added this pull request to the merge queue Feb 24, 2023
Merged via the queue into main with commit 7366cbf Feb 24, 2023
@mmalenic mmalenic deleted the refactor-tests branch February 24, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove circular dependency involving htsget-test and htsget-search
2 participants