refactor!: refactor tests to avoid a circular dependency with htsget-search and htsget-http #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #158
This PR refactors
htsget-tests
to avoid a circular dependency withhtsget-search
andhtsget-http
.Implementation
http-tests
to avoid using the structs inhtsget-search
andhtsget-http
.serde_json
Value
. This also probably makes the tests more robust as they no longer dependent on the implementation of thehtsget-http
structs.CertificateKeyPair
to config to avoid repeating the logic inhtsget-tests
and simplifying logic inhtsget-search
. This is a breaking change as it removes theTryFrom<DataServerConfig> for HttpTicketFormatter
implementation.