Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dead code warnings for async/blocking versions #63

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Fix dead code warnings for async/blocking versions #63

merged 7 commits into from
Sep 28, 2021

Conversation

brainstorm
Copy link
Member

Fixes issue #61

@brainstorm brainstorm requested review from CastilloDel and mmalenic and removed request for CastilloDel September 17, 2021 01:35
CastilloDel
CastilloDel suggested changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@CastilloDel CastilloDel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running cargo run -p htsget-http-actix --no-default-features to use the blocking version results in a lot of compiler errors.

htsget-http-actix/src/main.rs Outdated Show resolved Hide resolved
htsget-http-actix/src/main.rs Outdated Show resolved Hide resolved
@brainstorm
Copy link
Member Author

Fixed! Turned out that the blocking impl needs async on the handler side of actix-web, see commit 8824d82.

Review & merge, plz @CastilloDel and/or @mmalenic ? ;)

@brainstorm brainstorm merged commit 5d5a9ae into main Sep 28, 2021
@brainstorm brainstorm deleted the dead_code_warning_async_blocking branch May 27, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalenic mmalenic Awaiting requested review from mmalenic

@CastilloDel CastilloDel Awaiting requested review from CastilloDel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brainstorm @CastilloDel