Implemented TokenService stack as stateful deployable artefact #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #127 |
reisingerf
approved these changes
Apr 7, 2024
lib/workload/stateful/token_service/deploy/token-service-stack.ts
Outdated
Show resolved
Hide resolved
lib/workload/stateful/token_service/deploy/token-service-stack.ts
Outdated
Show resolved
Hide resolved
lib/workload/stateful/token_service/token_service/cognitor/tests.py
Outdated
Show resolved
Hide resolved
williamputraintan
approved these changes
Apr 7, 2024
victorskl
added a commit
to umccr/infrastructure
that referenced
this pull request
Apr 8, 2024
* Improved by explicitly set the allow auth flows and, token unit type and, their expiry values. * Used in OrcaBus TokenService stack umccr/orcabus#197
victorskl
added a commit
to umccr/infrastructure
that referenced
this pull request
Apr 8, 2024
* Enabled COGNITO as supported IdP for Portal app client * Added `users.tf` to track Portal Service User registry. See its TF docstring for details. Related umccr/orcabus#197
victorskl
force-pushed
the
implement-stateful-token-service
branch
from
89e5e86
to
32cdc48
Compare
* Leveraged AWS secret rotation code template * Made the Token Service as a Stack in stateful deployment and from lookup to (re)constructs existing resources when it needs * Refactored minor to `stateful-deployment.test.ts` to fit cdk-nag Resolves #182
* Minor refactored cdk code stack and rearranged program routines * Renamed the file to stack.ts Co-authored-by: @reisingerf
victorskl
force-pushed
the
implement-stateful-token-service
branch
from
32cdc48
to
adee447
Compare
* As advised by @reisingerf
|
Surprise that no conflict reported so far.! Please have a skim through one more time, if you can. Otherwise, I will finalise & merge it tomorrow. And then, start deploying, testing and debugging phase in DEV. (taking deep breath) 🤞 |
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from lookup to (re)constructs existing resources when it needs
stateful-deployment.test.tsto fit cdk-nagResolves #182