Actually use a production environment in our production setup #218
+219
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: `docker-compose.yml` sets relevant env variables to production, uses production rake start command - fix: `better-errors` was installed, but was never being used.
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 84.12% 83.94% -0.18%
==========================================
Files 46 46
Lines 1864 1869 +5
==========================================
+ Hits 1568 1569 +1
- Misses 296 300 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our production setup was actually running in 'development' - sure, it's not using
shotgun, but all development dependencies were still being installed, and bothrackandpumawere configured for development. This PR fixes this.Additionally,
better-errorswas not working because of our use of docker. By default, it is configured to only returnbetter-errorserror pages when requests are fromlocalhost. This is now fixed, and errors in development should display code snippets from each part of an error's stacktrace.