Adds alignment property #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the dashed line would have an offset to the side, which in return wouldn't be as pleseant to look at in comparison to the divider, since it is this widget that hopefully this package is trying to replace to. So, by adding a property `alignment`, defaulted to `WrapAlignment.center`, one can achieve the desired alignment inside its application. If needed, this can be later changed by the developer to adjust for his/her scenario. This may close the issue umechanhika#25 - Feature: option to specify alignment.
umechanhika
approved these changes
Jun 10, 2023
There was a problem hiding this comment.
@filipe-varela
Thank you for your contribution!
This change looks great.
After merging this pull request, I will modify CHANGELOG.md and other files necessary for version updates, and then publish it to pub.dev as a new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the dashed line would have an offset to the side, which in return wouldn't be as pleasant to look at in comparison to the divider, since it is this widget that hopefully this package is trying to replace to.
So, by adding a property
alignment, defaulted toWrapAlignment.center, one can achieve the desired alignment inside its application. If needed, this can be later changed by the developer to adjust for his/her scenario.This may close the issue #25 - Feature: option to specify alignment.