Leverage: (HAL-06) DUPLICATED ERROR CHECKS #1194
Assignees
Labels
Comments
|
What's the proposal? Error checks in |
|
we could just return the |
|
ah, right, that's super easy ;) we can even have a helper function for that. |
17 tasks
|
@RafilxTenfen I've created util functions for that: #1212 |
17 tasks
mergify bot
pushed a commit
that referenced
this issue
Aug 4, 2022
## Description Util package to remove repetitions in `sdk.Msg` interface implementation (ValidateBasic and GetSigners). This package can be extended in the future to provide more common check / validation functions. Ref: #1194 --- ### Author Checklist _All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues._ I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] added appropriate labels to the PR - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist _All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items._ I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
There are two instances where an error check is not required, and the logic can be adjusted to only return the value
Problem Definition
Proposal
As the err variable will already be nil if no error has been generated by the function, the following piece of code will be sufficient
For Admin Use
The text was updated successfully, but these errors were encountered: