Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enaable ibctransfer wrapper test suite #1280

Merged
merged 12 commits into from
Sep 11, 2022
Merged

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Aug 25, 2022

Description

Closes: #1259


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba changed the title tests: re-enaable ibctransfer wrapper test suite test: re-enaable ibctransfer wrapper test suite Sep 2, 2022
@robert-zaremba robert-zaremba marked this pull request as ready for review September 6, 2022 18:14
@robert-zaremba robert-zaremba requested review from a team as code owners September 6, 2022 18:14
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, Fix others CI's and we are good to merge

x/ibctransfer/keeper/keeper_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1280 (94d8172) into main (902ebae) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
+ Coverage   52.29%   52.35%   +0.06%     
==========================================
  Files          70       70              
  Lines        6812     6784      -28     
==========================================
- Hits         3562     3552      -10     
+ Misses       2976     2964      -12     
+ Partials      274      268       -6     
Impacted Files Coverage Δ
x/leverage/keeper/invariants.go 73.10% <100.00%> (+3.93%) ⬆️

@mergify mergify bot merged commit 0afaf70 into main Sep 11, 2022
@mergify mergify bot deleted the robert/ibctransfer-tests branch September 11, 2022 13:10
@robert-zaremba robert-zaremba mentioned this pull request Sep 11, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable and investigate ibctransfer failing tests
5 participants