Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable upgrade ci #1366

Merged
merged 1 commit into from
Sep 10, 2022
Merged

ci: disable upgrade ci #1366

merged 1 commit into from
Sep 10, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 10, 2022

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki requested a review from a team as a code owner September 10, 2022 02:12
@RafilxTenfen RafilxTenfen merged commit d15d6e5 into main Sep 10, 2022
@RafilxTenfen RafilxTenfen deleted the disable-upgrade-ci branch September 10, 2022 13:34
@robert-zaremba
Copy link
Member

I think we should run this tests before making the release.

  1. Either we do it as required for specific type of PR
  2. or run it locally by the release team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants