chore: add atom to default registry #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamewozniak
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
+ Coverage 52.52% 52.96% +0.44%
==========================================
Files 70 70
Lines 6692 6751 +59
==========================================
+ Hits 3515 3576 +61
+ Misses 2909 2907 -2
Partials 268 268
|
toteki
reviewed
Sep 15, 2022
toteki
approved these changes
Sep 18, 2022
… into woz/atom-default-denom
toteki
reviewed
Sep 18, 2022
| MinCollateralLiquidity: sdk.MustNewDecFromStr("0"), | ||
| MaxSupply: sdk.NewInt(100000000000), | ||
| }, | ||
| } |
There was a problem hiding this comment.
we need to Atom as well.
There was a problem hiding this comment.
This isn't the default registry, it's one that allows us to run CLI tests with UMEE only
There was a problem hiding this comment.
I know, but don't we need it for tests?
There was a problem hiding this comment.
Switching to default registry here would cause a few downstream tests to fail (they're expecting these specific values) but we can do that at a later date. Created #1414
robert-zaremba
approved these changes
Sep 18, 2022
… into woz/atom-default-denom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add atom's IBC denom to the default whitelist
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...