Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MinCollateralLiquidity validation #1405

Merged
merged 6 commits into from
Sep 18, 2022
Merged

fix: MinCollateralLiquidity validation #1405

merged 6 commits into from
Sep 18, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 18, 2022

Description

Fixes a copypasta in token validation that would allow us to set a parameter too high.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki requested a review from a team as a code owner September 18, 2022 00:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Merging #1405 (24a4f12) into main (4217dcc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files          70       70           
  Lines        6692     6692           
=======================================
  Hits         3515     3515           
  Misses       2909     2909           
  Partials      268      268           
Impacted Files Coverage Δ
x/leverage/types/token.go 72.52% <100.00%> (ø)

@toteki toteki requested a review from a team as a code owner September 18, 2022 02:45
@robert-zaremba
Copy link
Member

Let's merge this PR, however as noted in the comment above:

I think we should merge #1409 to avoid migration when we add that feature. We don't need to use that value, now.

#1409 contains tests, original fix, improved documentation and parameter we need anyway.

@mergify mergify bot merged commit d83990a into main Sep 18, 2022
@mergify mergify bot deleted the adam/fix branch September 18, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants