Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ante/fee): optimize requiredFees calculation #1418

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

robert-zaremba
Copy link
Member

Description

Ref: https://github.com/umee-network/umee/pull/1411/files#r973809128


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

ante/fee.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1418 (c4cfb1f) into main (4124ef7) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   52.83%   52.80%   -0.03%     
==========================================
  Files          70       70              
  Lines        6751     6751              
==========================================
- Hits         3567     3565       -2     
- Misses       2914     2916       +2     
  Partials      270      270              
Impacted Files Coverage Δ
ante/fee.go 78.35% <83.33%> (-2.07%) ⬇️

@toteki toteki merged commit 1f8bc6f into main Sep 19, 2022
@toteki toteki deleted the robert/zero-fee-optimization branch September 19, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants