Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo #1422

Merged
merged 5 commits into from
Sep 19, 2022
Merged

chore: fix typo #1422

merged 5 commits into from
Sep 19, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 19, 2022

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki requested a review from a team as a code owner September 19, 2022 05:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #1422 (dcda7ac) into main (1f8bc6f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1422   +/-   ##
=======================================
  Coverage   52.80%   52.80%           
=======================================
  Files          70       70           
  Lines        6751     6751           
=======================================
  Hits         3565     3565           
  Misses       2916     2916           
  Partials      270      270           
Impacted Files Coverage Δ
app/upgrades/v3/min_commission.go 85.71% <100.00%> (ø)

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toteki toteki changed the title DNM: adam/test chore: fix typo Sep 19, 2022
@toteki toteki merged commit ae66523 into main Sep 19, 2022
@toteki toteki deleted the adam/test branch September 19, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants