Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 4.1 upgrade handler #1772

Merged
merged 14 commits into from
Feb 8, 2023
Merged

chore: add 4.1 upgrade handler #1772

merged 14 commits into from
Feb 8, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Feb 2, 2023

Signed-off-by: Sai Kumar sai@umee.cc

Description

closes: #1702


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Sai Kumar <sai@umee.cc>
@gsk967 gsk967 changed the title add 4.1 upgrade handler chore: add 4.1 upgrade handler Feb 2, 2023
@gsk967 gsk967 marked this pull request as ready for review February 6, 2023 15:11
@gsk967 gsk967 requested a review from a team as a code owner February 6, 2023 15:11
@gsk967 gsk967 requested a review from a team as a code owner February 6, 2023 16:25
ante/spam_prevention_test.go Outdated Show resolved Hide resolved
ante/spam_prevention_test.go Outdated Show resolved Hide resolved
app/upgrades.go Show resolved Hide resolved
ante/spam_prevention_test.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep "cosmossdk.io/errors" without rename / alias, and sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" as sdkerrors

I have fixed other deprecation warnings in #1788

ante/spam_prevention_test.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

app/upgrades.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 397e0fc into main Feb 8, 2023
@mergify mergify bot deleted the sai/uibc_migration branch February 8, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ibc quota module migration to v4.1
2 participants