Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup deprecated code #2060

Merged
merged 2 commits into from
May 20, 2023
Merged

chore: cleanup deprecated code #2060

merged 2 commits into from
May 20, 2023

Conversation

robert-zaremba
Copy link
Member

No description provided.

@robert-zaremba robert-zaremba requested review from a team as code owners May 20, 2023 10:19
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #2060 (4d452dc) into main (7f05ad4) will decrease coverage by 4.81%.
The diff coverage is 59.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   75.38%   70.58%   -4.81%     
==========================================
  Files         100      126      +26     
  Lines        8025     9580    +1555     
==========================================
+ Hits         6050     6762     +712     
- Misses       1589     2352     +763     
- Partials      386      466      +80     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/leverage/types/keys.go 100.00% <ø> (ø)
x/leverage/types/proposal.go 33.33% <0.00%> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/oracle/types/keys.go 90.47% <ø> (ø)
x/oracle/types/msgs.go 81.05% <0.00%> (ø)
... and 54 more

... and 2 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsk967 gsk967 added this pull request to the merge queue May 20, 2023
Merged via the queue into main with commit f5b9f2e May 20, 2023
24 of 25 checks passed
@gsk967 gsk967 deleted the robert/remove-legacy-module branch May 20, 2023 13:57
@toteki toteki mentioned this pull request May 22, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants