Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove beta build flag #643

Merged
merged 6 commits into from
Mar 14, 2022
Merged

chore: remove beta build flag #643

merged 6 commits into from
Mar 14, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

  • Replace the current mainnet app with the beta app (anything needing to be backported to mainnet can be branched directly off of release/v1.x.x.
  • Remove all beta build flags & logic

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -572,6 +618,9 @@ func New(
evidence.NewAppModule(app.EvidenceKeeper),
ibc.NewAppModule(app.IBCKeeper),
transferModule,
oracle.NewAppModule(appCodec, app.OracleKeeper, app.AccountKeeper, app.BankKeeper),
// TODO: Ensure x/leverage implements simulator and then uncomment.
// leverage.NewAppModule(appCodec, app.LeverageKeeper, app.AccountKeeper, app.BankKeeper),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @toteki

@@ -25,6 +25,8 @@ import (
var (
_ module.AppModule = AppModule{}
_ module.AppModuleBasic = AppModuleBasic{}
// TODO: Ensure x/leverage implements simulator and then uncomment.
// _ module.AppModuleSimulation = AppModule{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @toteki

@alexanderbez
Copy link
Contributor Author

@dreamcodez I think there are few tweaks that need to be made to infra/* so I'll let you tackle that in a separate PR after this is merged.

@codecov-commenter
Copy link

Codecov Report

Merging #643 (cb0a1e6) into main (1695b76) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files          64       64           
  Lines        8841     8841           
=======================================
  Hits         4246     4246           
  Misses       4332     4332           
  Partials      263      263           
Impacted Files Coverage Δ
x/leverage/module.go 56.25% <ø> (ø)
x/leverage/client/tests/suite.go 100.00% <100.00%> (ø)
x/leverage/client/tests/util.go 87.69% <100.00%> (ø)
x/oracle/client/tests/suite.go 98.36% <100.00%> (ø)

@alexanderbez alexanderbez marked this pull request as ready for review March 14, 2022 14:43
@alexanderbez alexanderbez requested a review from a team as a code owner March 14, 2022 14:43
@alexanderbez alexanderbez merged commit 18f3eb1 into main Mar 14, 2022
@alexanderbez alexanderbez deleted the bez/remove-beta branch March 14, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants