Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CollateralValue and LiquidationLimit queries #658

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Conversation

toteki
Copy link
Member

@toteki toteki commented Mar 17, 2022

Description

Plus some typo fixes in query proto file


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review March 17, 2022 07:05
@toteki toteki requested review from a team as code owners March 17, 2022 07:05
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez
Copy link
Contributor

@toteki TestQueryCollateralValue is failing

@codecov-commenter
Copy link

Codecov Report

Merging #658 (a5e1f15) into main (a103a34) will increase coverage by 0.07%.
The diff coverage is 49.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   48.05%   48.13%   +0.07%     
==========================================
  Files          64       64              
  Lines        8858     9291     +433     
==========================================
+ Hits         4257     4472     +215     
- Misses       4337     4555     +218     
  Partials      264      264              
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 6.31% <0.00%> (-1.03%) ⬇️
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <100.00%> (ø)

@alexanderbez alexanderbez merged commit 8b9ec35 into main Mar 17, 2022
@alexanderbez alexanderbez deleted the adam/query branch March 17, 2022 14:31
@alexanderbez
Copy link
Contributor

@Mergifyio backport release/v0.8.x

mergify bot pushed a commit that referenced this pull request Mar 17, 2022
(cherry picked from commit 8b9ec35)

# Conflicts:
#	x/leverage/client/tests/suite.go
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2022

backport release/v0.8.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants