Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posibility of a 2.6.3 release with less strict eslint-plugin-markdown version dependency #98

Closed
evansrobert opened this issue Aug 10, 2021 · 1 comment

Comments

@evansrobert
Copy link

evansrobert commented Aug 10, 2021

Hi, @chenshuai2144,

Issue Description

I noticed that a vulnerability is introduced in @umijs/fabric@2.6.2:
Vulnerability CVE-2020-7753 (high severity) affects package trim (versions:<0.0.3): https://snyk.io/vuln/SNYK-JS-TRIM-1017038
The above vulnerable package is referenced by @umijs/fabric@2.6.2 via:
@umijs/fabric@2.6.2 ➔ eslint-plugin-markdown@1.0.2 ➔ remark-parse@5.0.0 ➔ trim@0.0.1

Since @umijs/fabric@2.6.2 (12,820 downloads per week) is referenced by 55 downstream projects (e.g., sylvanas 0.6.1 (latest version), @ant-design/pro-cli 2.1.5 (latest version), @umijs/block-sdk 2.3.0 (latest version), @ant-design/bisheng-plugin 2.3.1 (latest version), @umijs/preset-ui 2.2.9 (latest version)), the vulnerability CVE-2020-7753 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths:
(1)@ant-design/bisheng-plugin@2.3.1 ➔ sylvanas@0.6.1 ➔ @umijs/fabric@2.6.2 ➔ eslint-plugin-markdown@1.0.2 ➔ remark-parse@5.0.0 ➔ trim@0.0.1
(2)@umijs/block-sdk@2.3.0 ➔ sylvanas@0.6.1 ➔ @umijs/fabric@2.6.2 ➔ eslint-plugin-markdown@1.0.2 ➔ remark-parse@5.0.0 ➔ trim@0.0.1
......

If @umijs/fabric@2.6.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from @umijs/fabric@2.6.2* ?

Fixing suggestions

In @umijs/fabric@2.6.3, you can kindly perform the following upgrade :
eslint-plugin-markdown ^1.0.0 ➔ ^2.2.0;

Note:
eslint-plugin-markdown@2.2.0(>=2.2.0) doesn’t depends on trim any more.
Of course, you are welcome to share other ways to resolve the issue.

Thank you for your attention to this issue.

@chenshuai2144
Copy link
Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants