Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getSlaveRuntime #548

Merged
merged 3 commits into from
Mar 4, 2021
Merged

fix: getSlaveRuntime #548

merged 3 commits into from
Mar 4, 2021

Conversation

snadn
Copy link
Contributor

@snadn snadn commented Mar 2, 2021

适配 export const qiankun 为异步函数的场景

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #548 (c07bfd7) into master (cc55724) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files          66       66           
  Lines        1542     1542           
  Branches      424      424           
=======================================
  Hits          734      734           
  Misses        807      807           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc55724...c07bfd7. Read the comment docs.

Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面有几个调用 getSlaveRuntime 方法的地方都需要加下 await

Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job!

@kuitos kuitos merged commit 6cee8e6 into umijs:master Mar 4, 2021
@kuitos
Copy link
Member

kuitos commented Mar 4, 2021

released v2.22.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants