filmAVF #185
Merged
filmAVF #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment now working, force frame update when switching colorspace
…dy reading a new frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filmAVF AVFoundation backend is basically working AFAICT. All 3 colorspaces supported.
This should be tested, especially for performance as my testing only loaded and used 1 file without doing anything advanced or fancy.
Note: I changed the name to "filmAVF" as it better follows the existing "filmQT" naming and it's shorter. The only con is it could be confused with "filmAVI".
EDIT: Switching colorspaces on the fly works, but you need to manually set the frame to update the current image. I may try to make this automatic but was having the problem of the update actually loading the next frame instead of just refreshing the current one.