Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the code and fix backward compatibility #5

Closed
wants to merge 1 commit into from

Conversation

avilleret
Copy link
Contributor

Signed-off-by: Antoine Villeret antoine.villeret@gmail.com

and fix backward compatibility

Signed-off-by: Antoine Villeret <antoine.villeret@gmail.com>
@umlaeute
Copy link
Owner

umlaeute commented Jan 9, 2014

i don't see how this retains backwards compatibility as compared to your original version with your fixes.

what's more i find this behaviour slightly irritating:

  1. create [gemvertexbuffer 100]
  2. send it a [draw_range 10 30( message
  3. send it a [resize 120( message
  4. it will have an effective range of 10..120 ???

@umlaeute umlaeute closed this Jan 9, 2014
@avilleret
Copy link
Contributor Author

in the original version, the range indexes are not set automatically
in the new version, the start index is set to 0 on startup
and the end is set to vbo_size at startup and on [resize( message
but it seems to be a bad idea to reset the end index on [resize(
it could be easily fixed
but I'm wondering the need to resize while still using a smaller range ?

@umlaeute
Copy link
Owner

umlaeute commented Jan 9, 2014

On 2014-01-09 14:49, Antoine Villeret wrote:

in the original version, the range indexes are not set automatically
in the new version, the start index is set to 0 on startup
and the end is set to vbo_size at startup and on [resize( message
but it seems to be a bad idea to reset the end index on [resize(
it could be easily fixed
but I'm wondering the need to resize while still using a smaller range ?

does my current 'master' works as you expect it?

gfsdmtr
IOhannes

@avilleret
Copy link
Contributor Author

sorry I didn't see your modification before making mine...
and yes it works as I expect
in my case, I let OpenGL doing the check and throwing a "GL : invalid
enumerant" in the Pd console
your version is more "ceinture-bretelle" (a french expression to denote a
double security)
but works fine and is more silent

thanks for your time

a

do it yourself
http://antoine.villeret.free.fr

2014/1/9 umläute notifications@github.com

On 2014-01-09 14:49, Antoine Villeret wrote:

in the original version, the range indexes are not set automatically
in the new version, the start index is set to 0 on startup
and the end is set to vbo_size at startup and on [resize( message
but it seems to be a bad idea to reset the end index on [resize(
it could be easily fixed
but I'm wondering the need to resize while still using a smaller range ?

does my current 'master' works as you expect it?

gfsdmtr
IOhannes


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-31932476
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants