Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemvertexbuffer_shader #57

Merged
merged 16 commits into from
Sep 13, 2014
Merged

gemvertexbuffer_shader #57

merged 16 commits into from
Sep 13, 2014

Conversation

jptrkz
Copy link
Contributor

@jptrkz jptrkz commented Sep 11, 2014

thanks for the help

ending up doing this via command-line entirely - not such a bad thing to know how to do it seems

@umlaeute
Copy link
Owner

thanks this is much better.

for the future: rather than annotating each commit here in the pull-request, it would be better to do that within the commit.
e.g. in commit c4b28db, rather than just saying

copyArray fix

you should probably use this commit message:

copyArray fix

avoids a crash/unrendered geos (referenced from sourceforge code)

(and possibly also mention which "sourceforge code" you are referring to.

but keep this in mind for your next pull request :-)

@jptrkz
Copy link
Contributor Author

jptrkz commented Sep 13, 2014

yup - realized that commenting each commit was bad practice - but too late

i don't mind redoing this one more time

editing the file gradually for commits here on github would be very quick to do actually - but then there would be the encoding umlaeute issue again at the top of the cpp - would there be a way to avoid that?

@umlaeute
Copy link
Owner

don't worry this time

@umlaeute umlaeute merged commit edd152d into umlaeute:master Sep 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants