Set correct output buffer type in vidioc_dqbuf #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When userspace dequeues an output buffer from the driver, that buffer should have type V4L2_BUF_TYPE_VIDEO_OUTPUT. Previously we were providing the type from our internal buffer which is V4L2_BUF_TYPE_VIDEO_CAPTURE.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When userspace dequeues an output buffer from the driver, that buffer should
have type V4L2_BUF_TYPE_VIDEO_OUTPUT. Previously we were providing the type
from our internal buffer which is V4L2_BUF_TYPE_VIDEO_CAPTURE.
(I am trying to send video to the device using v4l2-ctl; it assumes the buffer returned from DQBUF has the correct type, and enqueues it again with QBUF without setting the type, so without this change it doesn't work.)