Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create modal class #78

Closed
ummahusla opened this issue Dec 19, 2016 · 8 comments
Closed

Create modal class #78

ummahusla opened this issue Dec 19, 2016 · 8 comments

Comments

@ummahusla
Copy link
Owner

No description provided.

@bobharley
Copy link
Contributor

I would like to help on this.

@ummahusla
Copy link
Owner Author

@bobharley Cool.

  • You will need to create a /js/script.js and put your all js logic there.
  • All styles go to same /styles folder.
  • Ignore SASS/LESS for now.

@bobharley
Copy link
Contributor

Okay, I'll start working on it.
I will be using bootstrap 4 modal as a reference.

@ummahusla
Copy link
Owner Author

@bobharley Sounds good for me

@bobharley
Copy link
Contributor

It's done. Check the PR.

@bobharley
Copy link
Contributor

@ummahusla I think you should add a build system, like gulp, for easy development. I had to setup my own.

@ummahusla
Copy link
Owner Author

@bobharley Thank you for the contribution. I've created a task for gulp. Might be a cool idea you could help with the gulp build first. Then, we can merge your PR for modal and you can carry on with tooltip. How do you feel about it?

@bobharley
Copy link
Contributor

@ummahusla yeah, I'll make another branch from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants