Add ability to support multiple ALBs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcincuber
suggested changes
Jul 30, 2020
main.tf
Outdated
| @@ -81,14 +81,23 @@ resource "aws_wafv2_web_acl" "main" { | |||
| # WAFv2 web acl association with ALB | |||
| ##### | |||
| resource "aws_wafv2_web_acl_association" "main" { | |||
| count = var.enabled && var.create_alb_association ? 1 : 0 | |||
| count = var.enabled && var.create_alb_association && var.alb_arn != "" ? 1 : 0 | |||
There was a problem hiding this comment.
With this change we are getting an error:
Error: Invalid count argument
on ../../main.tf line 84, in resource "aws_wafv2_web_acl_association" "main":
84: count = var.enabled && var.create_alb_association && var.alb_arn != "" ? 1 : 0
The "count" value depends on resource attributes that cannot be determined
until apply, so Terraform cannot predict how many instances will be created.
To work around this, use the -target argument to first apply only the
resources that the count depends on.
This is a common thing with count unfortunately. This would only work if you provide a specific string. When you reference a module it will fail. You can replicate that behaviour by running core example.
There was a problem hiding this comment.
it should be alright now, sorry for the delay
main.tf
Outdated
|
|
||
| resource_arn = var.alb_arn | ||
| web_acl_arn = aws_wafv2_web_acl.main[0].arn | ||
|
|
||
| depends_on = [aws_wafv2_web_acl.main] | ||
| } | ||
|
|
||
| resource "aws_wafv2_web_acl_association" "alb_list" { | ||
| count = var.enabled && var.create_alb_association ? length(var.alb_arn_list) : 0 |
There was a problem hiding this comment.
perhaps in this count we won't need var.create_alb_association and/or it should be replaced by length(var.alb_arn_list) > 0 something to test
There was a problem hiding this comment.
I fixed the initial issue and decided to keep create_alb_association, hope you don't mind
mohsen0
force-pushed
the
support_alb_list
branch
from
44ab78f
to
096580f
Compare
mohsen0
force-pushed
the
support_alb_list
branch
from
096580f
to
7da6f0f
Compare
marcincuber
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change adds the ability to add multiple ALBs to a single WAF setup.