Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a line in readme for windows users #35

Closed
wants to merge 1 commit into from
Closed

Added a line in readme for windows users #35

wants to merge 1 commit into from

Conversation

mattmezza
Copy link

In my Windows environment I couldn't set up Poedit with the README.md values provided, this line could have saved me an hour.

@@ -73,6 +73,7 @@ with the following options:
- List of extensions: `*.twig`
- Invocation:
- Parser command: `<project>/vendor/bin/twig-gettext-extractor --sort-output --force-po -o %o %C %K -L PHP --files %F`
- (Windows user having problems? Try to use this instead `C:\\Users\path\to\your\project\vendor\bin\twig-gettext-extractor.bat --sort-output --force-po -o %o %C %K -L PHP --files %F`)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference? .bat extension? Afaik twig-gettext-extractor.bat is not part of this project.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly yes. Without the .bat extension it doesn't work. I don't know if Poedit should resolve hte <project> tag depending on the path in which I am saving the .po file or not. I guess it does not. Therefore I think it is better to write a fake path, in this way users of this fantastic project can start using it faster without trying multiple times the Poedit configuration.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you renamed twig-gettext-extractor to twig-gettext-extractor.bat? This is odd, because it's PHP file.

I find your path confusing also because it refers to non existing bat file.

No, it does not replace it, but we can write explanation below:

Replace <project> with absolute path to your project.

I appreciate your efforts to make things clear for windows users, I'm just afraid not to confuse them with referring to non existing path/file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right! IT can be confusing somehow. But please add the line specifying that the project tag will not be replaced by Poedit!

I have just added the bat extension.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added on #37, please review.

@umpirsky umpirsky closed this May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants