Merge pull request #1563 from umple/issue#1409

Fixes #1409 "Cursor jumps to start of text window in UmpleOnline"
umple · Jun 14, 2020 · 35cc514 · 35cc514
2 parents 7cc45ec + b9d4e9f
commit 35cc514
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/umpleonline/scripts/allumple-min.js b/umpleonline/scripts/allumple-min.js
diff --git a/umpleonline/scripts/umple_action.js b/umpleonline/scripts/umple_action.js
@@ -1650,7 +1650,9 @@ Action.processTyping = function(target, manuallySynchronized)
 
       // issue#1554
       var downloadLink = document.getElementById("downloadLink");
-      downloadLink.remove();
+      if (downloadLink !== null){
+        downloadLink.remove();
+      }
 
       Page.enablePaletteItem("buttonSyncDiagram", false);
     }

diff --git a/umpleonline/scripts/umple_system.js b/umpleonline/scripts/umple_system.js
@@ -393,10 +393,12 @@ UmpleSystem.update = function()
     this.umpleAssociations[i].setOffsetTwoPosition(screenPosition2);
     UmpleSystem.redrawAssociation(this.umpleAssociations[i]);
   }
-  for(var i = 0; i<this.umpleClasses.length;++i)
-  {
-    UmpleSystem.trimOverlappingAssociations(this.umpleClasses[i]);
-  }
+  // issue#1409  this block of code will trim blank part of the diagram, 
+  // which makes the diagram look worse and will eventually call the updateUmpleTextCallback() that set the cursor to positon (0,0). 
+  // for(var i = 0; i<this.umpleClasses.length;++i)
+  // {
+  //   UmpleSystem.trimOverlappingAssociations(this.umpleClasses[i]);
+  // }
 
 }