Fixes 984 and 992 #1006
Merged
Fixes 984 and 992 #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput files to go unreported. This bug has led to approximately 15 empty expected outputs files being included in the test suites. - Ran Umple for each of the empty test files and recorded the output in the appropriate empty expected output file (this have not been carefully checked, I'll be looking for help from more experienced contributor on this) - Removed one test file, ExampleFile.ump. This test case was exactly the same as the test case directly below it in AlloyTemplateTest.java - A static variable controlling the numbering of auto transitions was being carried over from test to test and producing variable outputs in StateMachineTest.java. Added code in StateMachineTest.java to clear the state of the Event object after each test.
-Added tests to verify correct 992 fix
…face doesn't explicitly include the interface's methods in its generated code.
…tempting to fix travis build failure by seperating tests in JavaInterfaceTemplateTest.java.
…re interface hierarchy. Adding additional tests to verify the fix.
|
The build didn’t pass CI on Mac. I’m looking into why, sorry! I did a full build on my machine, I must have missed a failure somewhere
From: Vahdat Abdelzad [mailto:notifications@github.com]
Sent: February 26, 2017 8:57 PM
To: umple/umple <umple@noreply.github.com>
Cc: Adam Bolding-Jones <anb1@sfu.ca>; Author <author@noreply.github.com>
Subject: Re: [umple/umple] Fixes 984 and 992 (#1006)
Merged #1006 <#1006> .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1006 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AIkHsN3xR_xJkrN4T0kYC0qNj3E6ysNfks5rglesgaJpZM4MMsAa> . <https://github.com/notifications/beacon/AIkHsEeAdKD4p2YlRPtETQyx6RD-ePWLks5rglesgaJpZM4MMsAa.gif>
|
|
@vahdat-ab I did another full build locally, there aren't any errors. Here's the build output: I'm not sure what's wrong. I didn't have any problems locally, and the build completed on Linux successfully. Is there any way to run the CI again? Maybe it's just "one of those things"? |
|
I can't rerun the travis build for this since the PR has been merged... I'll try to figure out another way |
|
It looks like the travis checks on master with my changes included are fine: https://travis-ci.org/umple/umple/builds/205684014 |
|
@AdamBJ everything looks ok :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #993 (comment) for what this PR does. I'm making a new PR rather than using 993 because I rebased in a dumb way and messed up the commit history of the
984branch.