Hide unneeded show/hide separate tabs for Json and UmpleSelf. Fixes #1719 #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a major bug. The 'Show Files in Separate Tabs' is being hidden in all languages. The if-then-else logic is incorrect. |
|
Also, a PR title, please be more precise: A better title would have been "Hide unneeded show/hide separate tabs for Json and UmpleSelf. Fixes #1719". It is important, as indicated to show the fixed issue in the PR title, and describe what it does. Giving the word 'Fixed' followed by a hash symbol and the issue number will ensure the issue is closaed if/when the PR is merged. |
RalphNgassa
changed the title
|
I corrected the logic error. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated umpleonline scripts to prevent the show/hide tab option from appearing when either "Internal Umple Representation" or "Json" is chose as the generate dropdown option