Trim telegram audio captions to 1024 symbols #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/trim_captions
branch
from
2722090
to
47de8d4
Compare
paskal
force-pushed
the
paskal/trim_captions
branch
from
47de8d4
to
d011c9a
Compare
umputun
requested changes
Mar 24, 2022
| @@ -75,7 +75,7 @@ func (client TelegramClient) Send(channelID string, item feed.Item) (err error) | |||
| func (client TelegramClient) sendText(channelID string, item feed.Item) (*tb.Message, error) { | |||
| message, err := client.Bot.Send( | |||
| recipient{chatID: channelID}, | |||
| client.getMessageHTML(item, true), | |||
| client.getMessageHTML(item, true, false), | |||
There was a problem hiding this comment.
a small suggestion: having two bool params one after another is hard to reason about, especially without IDE help. Adding a small private struct like sendParams and passing it, will make things more readable
| messageHTML := description | ||
|
|
||
| func (client TelegramClient) getMessageHTML(item feed.Item, withMp3Link, trimCaption bool) string { | ||
| var header, footer string | ||
| title := strings.TrimSpace(item.Title) | ||
| if title != "" { |
There was a problem hiding this comment.
this if/switch construct is a little bit award. Isn't all of this just a couple of ifs? i.e. title != "" && item.Link == "" and title != "" && item.Link != ""
|
I'll merge it as it solves a real problem. Feel free to adress comments as you have a moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR allows posting audio with long captions to Telegram.