New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix golangcilint errors on err variable reassignment #88

Merged

umputun merged 1 commit into master from paskal/fix_golangcilint

Apr 22, 2022

Sponsor Collaborator

paskal commented Apr 22, 2022 •

edited

sloppyReassign: re-assignment to `err` can be replaced with `err := tmpFile.Close()` (gocritic)

Also, I noticed that error is not attributed to the right line, a change in ci.yaml fixes that.

paskal requested a review from umputun as a code owner

April 22, 2022 07:03


          fix golangcilint errors on err variable reassignment

0eee4ae

Also, fix golangci-lint errors formatting for GitHub.

paskal force-pushed the paskal/fix_golangcilint branch from 5d1e51e to 0eee4ae Compare

April 22, 2022 07:05

umputun merged commit 2b39932 into master

umputun deleted the paskal/fix_golangcilint branch

April 22, 2022 07:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment