always publish reports

umputun · Aug 26, 2022 · c5bc190 · c5bc190
1 parent ec00576
commit c5bc190
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 18 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -28,4 +28,4 @@ debug.test
 *.test
 remark42
 /backend/var/
-playwright-report
+/playwright-report/
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
@@ -27,7 +27,7 @@ jobs:
         run: COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 docker-compose -f compose-e2e-test.yml up --build --quiet-pull --exit-code-from tests
 
       - uses: actions/upload-artifact@v2
-        if: failure() && steps.tests.outcome != 'success'
+        if: always()
         with:
           name: playwright-report
           path: ./playwright-report/

diff --git a/.gitignore b/.gitignore
@@ -24,4 +24,4 @@ compose-private-frontend.yml
 compose-private.yml
 /backend/_example/*/vendor
 http-client.env.json
-/playwright-report/
+/playwright-report/
diff --git a/backend/vendor/github.com/go-pkgz/auth/auth.go b/backend/vendor/github.com/go-pkgz/auth/auth.go
diff --git a/compose-e2e-test.yml b/compose-e2e-test.yml
@@ -15,14 +15,14 @@ services:
     container_name: "remark42"
 
     environment:
+      # remark42 hostname used for proper dev auth work for tests container which connects to it
+      # using the such hostname (unlike local development where 127.0.0.1 is used)
       - REMARK_URL=http://remark42:8080
       - SECRET=12345
       - DEBUG=true
       - ADMIN_PASSWD=password
-      - AUTH_DEV=true # activate local oauth "dev"
+      - AUTH_DEV=true # activate local OAuth "dev" listening on http://remark42:8084
       - ADMIN_SHARED_ID=dev_user # set admin flag for default user on local oauth2
-      - POSITIVE_SCORE=false # restricts comment's score to be only positive
-      - EDIT_TIME=5m # edit window
       - AUTH_ANON=true
       - AUTH_EMAIL_ENABLE=true
     volumes: