Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons for MD formatting #299

Closed
umputun opened this issue Apr 5, 2019 · 5 comments
Closed

Buttons for MD formatting #299

umputun opened this issue Apr 5, 2019 · 5 comments

Comments

@umputun
Copy link
Owner

umputun commented Apr 5, 2019

Having a typical toolbar for the comment composer can be helpful. Something like the one we see on github or gitlab

x9vfh-201904-05115349-babeo

aiq3o-201904-05115519-gnh6k

@Mavrin
Copy link
Collaborator

Mavrin commented Apr 10, 2019

Could we use a more user-friendly editor. Of course, it’s a good idea to limit the formatting options for the end user. It seems to me, it will a good solution, if the mark will use something looks like https://prosemirror.net/examples/markdown/. What do you think about it?

@Mavrin
Copy link
Collaborator

Mavrin commented Apr 10, 2019

Oh, I see, you use server render for preview. And client render is not appreciated solution for that case.

@umputun
Copy link
Owner Author

umputun commented Apr 10, 2019

  • Currently, we do the server-side rendering for preview. With such editor, it could be a non-trivial task to keep preview and WYSIWYM in full sync
  • It is unclear to me how much this thing extendable for functionality we need, like image drag-drop, counts and limits
  • I'm not even sure if rich formatting for comments is a thing. I think 90% of users expecting a place to write a plain text, and maybe another 10% may want to drop a picture.

@Mavrin
Copy link
Collaborator

Mavrin commented Apr 10, 2019

I suggest using WYSIWYG as your default editor.
I see problem only with your first point.
The second point possible solve by plugin https://prosemirror.net/examples/upload/ (drag-drop can be add)
Prosemirror generate pure plain text (try switch radio button between markdown and WYSIWYM in exapmle). If we are going add formatting button, why we should show intermediate view for user.

@Mavrin
Copy link
Collaborator

Mavrin commented Apr 10, 2019

Whatever, it is not simple add synced server and client render. And it is good idea add simple button for textarea.

Mavrin added a commit to Mavrin/remark that referenced this issue Apr 11, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 12, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Apr 14, 2019
umputun added a commit that referenced this issue Apr 15, 2019
#299 add toolbar for markdown formatting
@umputun umputun added this to the v1.3 milestone Apr 15, 2019
@umputun umputun closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants