Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button for image upload #371

Closed
umputun opened this issue Jul 12, 2019 · 12 comments
Closed

Add a button for image upload #371

umputun opened this issue Jul 12, 2019 · 12 comments

Comments

@umputun
Copy link
Owner

umputun commented Jul 12, 2019

Apparently, users have no idea pictures can be dropped into comments. In addition, there is no way to do it on the mobile version. Will be nice to add an image upload button to the toolbar with a hint saying something about drag-and-drop as well.

@umputun
Copy link
Owner Author

umputun commented Jul 12, 2019

ping @Mavrin

@Mavrin
Copy link
Collaborator

Mavrin commented Jul 12, 2019

What do you think about this?
Screen Shot 2019-07-12 at 11 35 02 AM

@umputun
Copy link
Owner Author

umputun commented Jul 12, 2019

I'm not sure why this button has a text label

@Mavrin
Copy link
Collaborator

Mavrin commented Jul 12, 2019

Because it not clear, what that icon will do. For example, gitlab and github describe how to upload files.
Of course it is not problem to remove text label

@umputun
Copy link
Owner Author

umputun commented Jul 12, 2019

well, other buttons are not clear the same way, but the tooltip is enough to figure.

@umputun
Copy link
Owner Author

umputun commented Jul 12, 2019

@Reeywhaar is cut-and-paste images via clipboard suppose to work? I think it worked once, but can be wrong

@Reeywhaar
Copy link
Collaborator

No, there is no any code related to this.

@umputun
Copy link
Owner Author

umputun commented Jul 12, 2019

No, there is no any code related to this.

Can we add some code related to this? I mean if not a big deal will be nice to support it. To me, such functionality looks exotic, but somehow users expect it to work with the clipboard as well

@Reeywhaar
Copy link
Collaborator

Yeah, I am myself find this feature good to have. Github has this, so I think it's totally possible.

Mavrin added a commit to Mavrin/remark that referenced this issue Jul 13, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 13, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 14, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 15, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 15, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 15, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 15, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 15, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 15, 2019
Mavrin added a commit to Mavrin/remark that referenced this issue Jul 16, 2019
umputun pushed a commit that referenced this issue Jul 16, 2019
* #371 add image icon for toolbar

* #371 add file upload handler

* #371 upload image from clipboard

* #371 change title and decrease size for upload button

* #371 allow upload few files

* #371 prevent paste text after file was uploaded in firefox
@umputun umputun added this to the v1.4 milestone Jul 16, 2019
@umputun umputun closed this as completed Jul 16, 2019
@umputun umputun mentioned this issue Jul 27, 2019
@mohammedi-haroune
Copy link

The upload button is still missing from the demo ? is it available for self-hosted installation ?
remark42

@umputun
Copy link
Owner Author

umputun commented Mar 26, 2020

I can see it on the demo site:

buxvqovxat-20200326-022447

The only reason I can think of - you logged as anonymous. In this case image upload disabled by design https://github.com/umputun/remark42/blob/master/backend/app/rest/api/rest.go#L320

@mohammedi-haroune
Copy link

Thank you @umputun for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants