Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject admin names for anonymous and (maybe) email auth #605

Closed
umputun opened this issue Mar 5, 2020 · 7 comments · Fixed by #612
Closed

Reject admin names for anonymous and (maybe) email auth #605

umputun opened this issue Mar 5, 2020 · 7 comments · Fixed by #612
Labels
Milestone

Comments

@umputun
Copy link
Owner

umputun commented Mar 5, 2020

With those auth methods, bad guys can try to impersonate and pick one of admin's names. This is visible but may confuse users.

We should reject such names at least on the backend side for anonymous. Regarding email auth - unclear, because this could be a valid way for real admin to login

@umputun umputun added the backend label Mar 5, 2020
@Mavrin
Copy link
Collaborator

Mavrin commented Mar 5, 2020

Maybe we can add some badge for real admin. Your idea will not work for non-english users.

@umputun
Copy link
Owner Author

umputun commented Mar 5, 2020

Your idea will not work for non-english users.

What do you mean?

@Mavrin
Copy link
Collaborator

Mavrin commented Mar 5, 2020

Sorry, I didn`t understand the problem correctly. But another case, how it should work for github if I change name?
Screen Shot 2020-03-05 at 11 51 24

@umputun
Copy link
Owner Author

umputun commented Mar 5, 2020

The goal is to restrict free-form user names, i.e. anonymous and maybe email. Possible collisions via social logins is another issue, outside of the scope of this ticket.

can add some badge for real admin

not a bad idea indeed. Currently, admins highlighted with a different color, but this is not very obvious.

@alexeyten
Copy link

umputun
umрutun
umpиtuп

@akellbl4
Copy link
Collaborator

akellbl4 commented Mar 7, 2020

First of all admin users are verified users and I think that badge together with different color of username are good enough for marking admins.
I think any name filled by user must be rejected if it is the same as any existed username.

@umputun
Copy link
Owner Author

umputun commented Mar 7, 2020

I think any name filled by user must be rejected if it is the same as any existed username.

There are two problems with this suggestion:

  1. Generally, we don't know "any existed username"
  2. For common names, this could be way too restrictive

@umputun umputun added this to the v1.6 milestone Apr 12, 2020
umputun added a commit that referenced this issue Jan 20, 2021
* fix admin name check for anon login #605

* update readme with admin names info

* lint: list of static site params

* typo

* don't allow email users to reuse admin names

* move admin.names to restricted-names

* forgotten names member

* remove names from example admin

* remove names from prepTestStore
akellbl4 pushed a commit that referenced this issue Jan 27, 2021
* fix admin name check for anon login #605

* update readme with admin names info

* lint: list of static site params

* typo

* don't allow email users to reuse admin names

* move admin.names to restricted-names

* forgotten names member

* remove names from example admin

* remove names from prepTestStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants