Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new error message and correct another one #1006

Merged
merged 2 commits into from
May 16, 2021
Merged

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 requested review from umputun and paskal May 16, 2021 09:50
@akellbl4 akellbl4 added this to the v1.9 milestone May 16, 2021
Co-authored-by: Dmitry Verkhoturov <paskal.07@gmail.com>
@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #1006 (1b8e948) into master (6d4be02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   43.98%   43.98%           
=======================================
  Files         127      127           
  Lines        2903     2903           
  Branches      662      662           
=======================================
  Hits         1277     1277           
  Misses       1613     1613           
  Partials       13       13           
Impacted Files Coverage Δ
frontend/app/utils/errorUtils.ts 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ef3ff...1b8e948. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 2.25 KB (0%)
public/remark.mjs 65.39 KB (+0.09% 🔺)
public/remark.css 9.42 KB (0%)
public/last-comments.mjs 30.12 KB (+0.18% 🔺)
public/last-comments.css 5.05 KB (0%)
public/deleteme.mjs 9.76 KB (+0.51% 🔺)
public/counter.mjs 601 B (0%)

@akellbl4 akellbl4 requested a review from paskal May 16, 2021 19:21
@umputun umputun merged commit cbdf5f1 into master May 16, 2021
@umputun umputun deleted the error-messages branch May 16, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make distinct error message on images validation errors
3 participants