Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error return from ExtractPictures #1009

Merged
merged 1 commit into from
May 18, 2021

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented May 17, 2021

That function returns an error in a never expected condition, and that error would be logged message on the caller side: none of the callers handles it.

That change hides that error from the caller so that function would have a signature that better fit what it does and how it behaves.

@paskal paskal requested a review from umputun as a code owner May 17, 2021 00:31
@paskal paskal force-pushed the paskal/simplify_extract_pictures branch from bdc9bfb to 5edf357 Compare May 17, 2021 00:33
That function returns an error in a never
expected condition, and that error would be
logged message on the caller side:
none of the callers handles it.

That change hides that error from the caller
so that function would have a signature that
better fit what it does and how it behaves.
@paskal paskal force-pushed the paskal/simplify_extract_pictures branch from 5edf357 to 0fca6a3 Compare May 17, 2021 07:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 848859630

  • 6 of 8 (75.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 83.646%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/store/image/image.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
backend/app/store/image/image.go 1 87.37%
Totals Coverage Status
Change from base Build 848814691: 0.09%
Covered Lines: 5396
Relevant Lines: 6451

💛 - Coveralls

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@umputun umputun merged commit 4d011aa into master May 18, 2021
@umputun umputun deleted the paskal/simplify_extract_pictures branch May 18, 2021 02:31
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants