Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor avatar #1011

Merged
merged 1 commit into from
May 17, 2021
Merged

refactor avatar #1011

merged 1 commit into from
May 17, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 requested a review from Mavrin May 17, 2021 15:00
@akellbl4 akellbl4 requested a review from umputun as a code owner May 17, 2021 15:00
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1011 (340086f) into master (cbdf5f1) will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   43.99%   44.01%   +0.01%     
==========================================
  Files         127      127              
  Lines        2905     2906       +1     
  Branches      656      658       +2     
==========================================
+ Hits         1278     1279       +1     
  Misses       1614     1614              
  Partials       13       13              
Impacted Files Coverage Δ
frontend/app/components/user-info/user-info.tsx 0.00% <0.00%> (ø)
frontend/app/components/avatar/avatar.tsx 100.00% <100.00%> (ø)
frontend/app/components/avatar/index.ts 100.00% <100.00%> (ø)
frontend/app/components/comment/comment.tsx 64.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9eb39d...340086f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 17, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.25 KB (0%)
public/remark.mjs 65.25 KB (-0.2% 🔽)
public/remark.css 9.42 KB (+0.03% 🔺)
public/last-comments.mjs 30.09 KB (-0.11% 🔽)
public/last-comments.css 5.07 KB (+0.47% 🔺)
public/deleteme.mjs 9.76 KB (0%)
public/counter.mjs 601 B (0%)

@akellbl4 akellbl4 force-pushed the avatar branch 2 times, most recently from 11b8f6f to 6323e77 Compare May 17, 2021 19:53
@umputun umputun merged commit 93b29e9 into master May 17, 2021
@umputun umputun deleted the avatar branch May 17, 2021 20:14
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid avatar link when importing from Disqus
4 participants