Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run CI pipelines on frontend Readme file change #1059

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Jul 25, 2021

On an example of #1057, I found that we run CI pipelines when Readme file changes in the frontend directory, which doesn't make sense.

@paskal paskal requested review from umputun and akellbl4 July 25, 2021 17:43
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #1059 (b7f5256) into master (68aba33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   44.18%   44.18%           
=======================================
  Files         126      126           
  Lines        2906     2906           
  Branches      653      617   -36     
=======================================
  Hits         1284     1284           
  Misses       1610     1610           
  Partials       12       12           
Impacted Files Coverage Δ
frontend/app/common/static-store.ts 100.00% <ø> (ø)
frontend/app/common/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad54a94...b7f5256. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 2.23 KB (0%)
public/remark.mjs 65.31 KB (0%)
public/remark.css 9.4 KB (0%)
public/last-comments.mjs 30.08 KB (0%)
public/last-comments.css 5.07 KB (0%)
public/deleteme.mjs 9.79 KB (0%)
public/counter.mjs 601 B (0%)

@akellbl4
Copy link
Collaborator

akellbl4 commented Jul 25, 2021

I don't think we need to run it on any .md file in frontend folder and in backend as well.

@umputun umputun merged commit c15a280 into master Jul 25, 2021
@umputun umputun deleted the paskal/bump-ci branch July 25, 2021 17:58
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants