Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable injection of last-comments.css in dev #1072

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Aug 1, 2021

...because it handled by webpack

...because it handled by webpack
@akellbl4 akellbl4 requested a review from umputun as a code owner August 1, 2021 17:11
@akellbl4 akellbl4 requested review from Mavrin and paskal August 1, 2021 17:11
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #1072 (f9fe82b) into master (f093d6a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   44.18%   44.16%   -0.02%     
==========================================
  Files         126      126              
  Lines        2906     2907       +1     
  Branches      617      654      +37     
==========================================
  Hits         1284     1284              
  Misses       1610     1610              
- Partials       12       13       +1     
Impacted Files Coverage Δ
frontend/app/last-comments.tsx 0.00% <0.00%> (ø)
frontend/app/components/user-info/user-info.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0efc04e...f9fe82b. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 1, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.23 KB (0%)
public/remark.mjs 65.31 KB (0%)
public/remark.css 8.68 KB (0%)
public/last-comments.mjs 30.08 KB (-0.01% 🔽)
public/last-comments.css 4.96 KB (0%)
public/deleteme.mjs 9.79 KB (0%)
public/counter.mjs 601 B (0%)

@umputun umputun merged commit b27a09f into master Aug 1, 2021
@umputun umputun deleted the disable-last-comments-css-dev branch August 1, 2021 21:08
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants