Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple small fixes to the backend #1155

Merged
merged 2 commits into from
Oct 25, 2021
Merged

multiple small fixes to the backend #1155

merged 2 commits into from
Oct 25, 2021

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Oct 25, 2021

  • regenerate mocks, so that go generate doesn't produce difference for the users
  • use require.NoError(t, err) in place of requre.Nil(t, err) for consistency
  • extract TelegramBotInfo structure, as it will be reused later on in the notifications subscription code

@paskal paskal added the backend label Oct 25, 2021
@paskal paskal requested a review from umputun October 25, 2021 21:31
@paskal paskal changed the title multiple small fixes to backend multiple small fixes to the backend Oct 25, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1383050148

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.827%

Totals Coverage Status
Change from base Build 1378472731: 0.03%
Covered Lines: 5831
Relevant Lines: 6956

💛 - Coveralls

@umputun umputun merged commit 8fc9141 into master Oct 25, 2021
@umputun umputun deleted the paskal/generic_fixes branch October 25, 2021 21:47
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants