Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copy for latest safari #1320

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix copy for latest safari #1320

merged 1 commit into from
Apr 13, 2022

Conversation

akellbl4
Copy link
Collaborator

Resolves #1312

  • updates typescript in order to have access to modern Clipboard API
  • modern browsers dropped ability to copy formatter text, that led to disabling this feature. now it's only simple text
  • fix for ts-ignore is needed, should be resolved in separate PR

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1320 (5222286) into master (000d64d) will increase coverage by 0.75%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   49.27%   50.03%   +0.75%     
==========================================
  Files         137      137              
  Lines        3042     3046       +4     
  Branches      693      695       +2     
==========================================
+ Hits         1499     1524      +25     
+ Misses       1527     1506      -21     
  Partials       16       16              
Impacted Files Coverage Δ
...ribe-by-email/comment-form__subscribe-by-email.tsx 90.51% <ø> (ø)
...ntend/app/components/comment-form/comment-form.tsx 49.28% <ø> (ø)
frontend/app/components/comment/comment.tsx 65.09% <16.66%> (-0.42%) ⬇️
frontend/app/common/copy.ts 96.29% <100.00%> (+92.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000d64d...5222286. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 10, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 124 ms (-39.01% 🔽) 164 ms
public/remark.mjs 66.02 KB (+0.14% 🔺) 1.4 s (+0.14% 🔺) 337 ms (+39.16% 🔺) 1.7 s
public/remark.css 8.26 KB (0%) 166 ms (0%) 0 ms (+100% 🔺) 166 ms
public/last-comments.mjs 31.07 KB (+0.35% 🔺) 622 ms (+0.35% 🔺) 142 ms (-30.81% 🔽) 763 ms
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 158 ms (+84.27% 🔺) 357 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 190 ms (+55.23% 🔺) 204 ms

@akellbl4
Copy link
Collaborator Author

@Mavrin I tried to provide some tests for copy function but they are really far from ideal. If you know a better way for testing clipboard I would appreciate any suggestions.
As far as I know the best way is to test it in headless browser.

Mavrin
Mavrin previously approved these changes Apr 13, 2022
@umputun
Copy link
Owner

umputun commented Apr 13, 2022

conflict

@umputun umputun merged commit a290d90 into master Apr 13, 2022
@umputun umputun deleted the fix/copy-in-safari branch April 13, 2022 17:15
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin "Copy" button doesn't work in Safari
4 participants