Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix light bg on dark theme #1332

Merged
merged 1 commit into from
Apr 14, 2022
Merged

fix light bg on dark theme #1332

merged 1 commit into from
Apr 14, 2022

Conversation

akellbl4
Copy link
Collaborator

color-scheme: dark makes iframe background lighter than original website.

Bug:
CleanShot 2022-04-13 at 20 05 15@2x

After fix:
CleanShot 2022-04-13 at 20 04 39@2x

@akellbl4 akellbl4 requested a review from Mavrin April 14, 2022 03:05
@akellbl4 akellbl4 requested a review from umputun as a code owner April 14, 2022 03:05
@umputun umputun merged commit cd7a2a3 into master Apr 14, 2022
@umputun umputun deleted the fix-background-on-dark-theme branch April 14, 2022 03:06
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 273 ms (-9.11% 🔽) 313 ms
public/remark.mjs 65.81 KB (-0.01% 🔽) 1.4 s (-0.01% 🔽) 932 ms (+9.86% 🔺) 2.3 s
public/remark.css 8.28 KB (+0.02% 🔺) 166 ms (+0.02% 🔺) 0 ms (+100% 🔺) 166 ms
public/last-comments.mjs 31.79 KB (0%) 636 ms (0%) 601 ms (+1% 🔺) 1.3 s
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 374 ms (+30.74% 🔺) 572 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 227 ms (-32.34% 🔽) 241 ms

@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants