Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show subscription buttons in simple view, add ability to hide rss button #1378

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jun 5, 2022

CleanShot 2022-06-05 at 15 22 54@2x

CleanShot 2022-06-05 at 15 24 19@2x

@akellbl4 akellbl4 requested review from paskal and Mavrin June 5, 2022 22:21
@akellbl4 akellbl4 requested a review from umputun as a code owner June 5, 2022 22:21
@akellbl4
Copy link
Collaborator Author

akellbl4 commented Jun 5, 2022

cc @reorx

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 201 ms (-2.47% 🔽) 242 ms
public/remark.mjs 65.97 KB (+0.15% 🔺) 1.4 s (+0.15% 🔺) 432 ms (+117.94% 🔺) 1.8 s
public/remark.css 8.17 KB (0%) 164 ms (0%) 0 ms (+100% 🔺) 164 ms
public/last-comments.mjs 31.96 KB (+0.04% 🔺) 640 ms (+0.04% 🔺) 220 ms (-1.16% 🔽) 859 ms
public/last-comments.css 3.78 KB (-0.03% 🔽) 76 ms (-0.03% 🔽) 0 ms (+100% 🔺) 76 ms
public/deleteme.mjs 9.93 KB (+0.11% 🔺) 199 ms (+0.11% 🔺) 211 ms (+18.03% 🔺) 410 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 143 ms (+2.59% 🔺) 158 ms

@akellbl4 akellbl4 force-pushed the add-notify-buttons-in-simple-view branch from e09b72c to 14d7213 Compare June 5, 2022 22:27
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #1378 (14d7213) into master (20ca089) will increase coverage by 1.55%.
The diff coverage is 83.60%.

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   50.34%   51.90%   +1.55%     
==========================================
  Files         139      138       -1     
  Lines        3011     2998      -13     
  Branches      642      695      +53     
==========================================
+ Hits         1516     1556      +40     
+ Misses       1488     1434      -54     
- Partials        7        8       +1     
Impacted Files Coverage Δ
frontend/app/common/static-store.ts 100.00% <ø> (ø)
frontend/app/components/comment/comment.tsx 62.05% <ø> (ø)
frontend/app/components/root/root.tsx 0.00% <ø> (ø)
frontend/app/remark.tsx 0.00% <0.00%> (ø)
frontend/app/store/theme/reducers.ts 0.00% <0.00%> (ø)
frontend/app/common/settings.ts 90.00% <88.88%> (-3.34%) ⬇️
...ntend/app/components/comment-form/comment-form.tsx 52.15% <96.77%> (+2.86%) ⬆️
frontend/app/components/textarea-autosize.tsx 93.33% <100.00%> (ø)
frontend/app/utils/isUserAnonymous.ts 100.00% <100.00%> (ø)
frontend/app/utils/parse-query.ts 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55f6ff...14d7213. Read the comment docs.

@umputun umputun merged commit fe4db30 into master Jun 6, 2022
@umputun umputun deleted the add-notify-buttons-in-simple-view branch June 6, 2022 15:00
@paskal paskal added this to the v1.10.2 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants