Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up node version #1403

Merged
merged 1 commit into from
Jul 2, 2022
Merged

up node version #1403

merged 1 commit into from
Jul 2, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jul 1, 2022

  • use latest LTS
  • add nvmrc
  • recommend NVM for version auto switch

@akellbl4 akellbl4 requested review from paskal and Mavrin July 1, 2022 18:15
@akellbl4 akellbl4 requested a review from umputun as a code owner July 1, 2022 18:15
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1403 (e04bd66) into master (24e9404) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   57.88%   57.88%           
=======================================
  Files         130      130           
  Lines        2885     2885           
  Branches      741      741           
=======================================
  Hits         1670     1670           
  Misses       1211     1211           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e9404...e04bd66. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 325 ms (+23.02% 🔺) 365 ms
public/remark.mjs 70.82 KB (0%) 1.5 s (0%) 837 ms (-18.91% 🔽) 2.3 s
public/remark.css 8.2 KB (0%) 165 ms (0%) 0 ms (+100% 🔺) 165 ms
public/last-comments.mjs 35.62 KB (+0.01% 🔺) 713 ms (+0.01% 🔺) 843 ms (+103.45% 🔺) 1.6 s
public/last-comments.css 3.79 KB (+0.03% 🔺) 76 ms (+0.03% 🔺) 0 ms (+100% 🔺) 76 ms
public/deleteme.mjs 10.01 KB (0%) 201 ms (0%) 192 ms (-13.19% 🔽) 393 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 278 ms (-1.54% 🔽) 293 ms

@akellbl4 akellbl4 marked this pull request as draft July 1, 2022 18:33
@akellbl4 akellbl4 marked this pull request as ready for review July 1, 2022 18:33
@umputun umputun merged commit 9971698 into master Jul 2, 2022
@umputun umputun deleted the up-node-version branch July 2, 2022 16:48
@paskal paskal added this to the v1.10.2 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants