Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci workflows #1418

Merged
merged 1 commit into from
Jul 22, 2022
Merged

update ci workflows #1418

merged 1 commit into from
Jul 22, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jul 13, 2022

unifies the way workflows defined, updates actions, gives names to jobs

Common:

  • run jobs on push only for master (we don't need to run them for every push to every branch, when PR is opened jobs will be run for each push, now it runs twice)
  • update actions/checkout to v3
  • add names to jobs for better readability in PRs

Backend:

Frontend:

  • move size-limit job to ci-frontend.yml

Site:

  • rename build-site to build because it's already prefixed with root name

CleanShot 2022-07-13 at 11 45 38@2x

@akellbl4 akellbl4 requested review from paskal and Mavrin July 13, 2022 18:43
@akellbl4 akellbl4 marked this pull request as ready for review July 13, 2022 18:46
@akellbl4 akellbl4 requested a review from umputun as a code owner July 13, 2022 18:46
@github-actions
Copy link

github-actions bot commented Jul 13, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.02 KB (0%)
public/remark.mjs 72.37 KB (-0.01% 🔽)
public/remark.css 8.2 KB (0%)
public/last-comments.mjs 35.51 KB (0%)
public/last-comments.css 3.79 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1418 (3e19591) into master (6625fac) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e19591 differs from pull request most recent head 65ed21a. Consider uploading reports for the commit 65ed21a to get more accurate results

@@           Coverage Diff           @@
##           master    #1418   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         131      131           
  Lines        2909     2909           
  Branches      743      743           
=======================================
  Hits         1691     1691           
  Misses       1087     1087           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6625fac...65ed21a. Read the comment docs.

@akellbl4 akellbl4 force-pushed the ci-workflows branch 2 times, most recently from 1ecadee to d198301 Compare July 13, 2022 19:47
@akellbl4
Copy link
Collaborator Author

akellbl4 commented Jul 13, 2022

@umputun
this snipper should do the thing. Run actions on every push and avoid running them twice on PR

pull_request:
  types: [opened, reopened]

https://github.com/umputun/remark42/pull/1418/files#diff-d534d457d2f453ff292b326309bebf3d6b2f7e067ca4247038b61df22d09c728R13

@akellbl4 akellbl4 force-pushed the ci-workflows branch 2 times, most recently from d7ebaf8 to 29df78d Compare July 13, 2022 19:58
@akellbl4
Copy link
Collaborator Author

Close and reopen in order to kickoff actions with recent changes

paskal
paskal previously approved these changes Jul 13, 2022
umputun
umputun previously approved these changes Jul 14, 2022
Mavrin
Mavrin previously approved these changes Jul 14, 2022
@akellbl4 akellbl4 force-pushed the workspaces branch 7 times, most recently from f9397be to 8dee468 Compare July 19, 2022 22:26
@paskal paskal force-pushed the workspaces branch 3 times, most recently from 7b187e8 to 07584ee Compare July 20, 2022 01:56
@akellbl4 akellbl4 force-pushed the workspaces branch 2 times, most recently from c967567 to c95e8e9 Compare July 21, 2022 22:16
Base automatically changed from workspaces to master July 21, 2022 23:27
@akellbl4 akellbl4 dismissed stale reviews from Mavrin, umputun, and paskal via 3e19591 July 22, 2022 00:32
@umputun umputun merged commit 3d1a3fd into master Jul 22, 2022
@umputun umputun deleted the ci-workflows branch July 22, 2022 00:52
@paskal paskal added this to the v1.10.2 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants