Move templates from rakyll/statik to go:embed #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/go_embed_templates
branch
3 times, most recently
from
c1880e2
to
a1bd81f
Compare
umputun
reviewed
Jul 27, 2022
paskal
force-pushed
the
paskal/go_embed_templates
branch
3 times, most recently
from
30e4f01
to
0dc9350
Compare
There is no need for the rakyll/statik package starting with Go 1.16, which provides us with tools for embedding files without third-party libraries.
paskal
force-pushed
the
paskal/go_embed_templates
branch
from
0dc9350
to
c25a239
Compare
umputun
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the rakyll/statik package starting with Go 1.16, which provides us with tools for embedding files without third-party libraries.
I've verified that binary reads files from the disk in case they are present with the same name as embedded ones. Changes in files are immediately seen on the page after refresh. To verify, try opening http://127.0.0.1:8080/email/unsubscribe.html and putting file
error_response.html.tmplnext to the library and altering it.