Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run size limit job outside of PRs #1448

Merged
merged 1 commit into from Jul 27, 2022
Merged

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Jul 27, 2022

Currently, this step emits the "Error: No PR found. Only pull_request workflows are supported." message when run on the master branch commits (after the merge), so the change prevents it from being run there.

Resolves #1433.

Currently, this step emits the
"Error: No PR found. Only pull_request workflows are supported."
message when run on the master branch commits (after the merge),
so the change prevents it from being run there.
@paskal paskal requested a review from umputun as a code owner July 27, 2022 22:23
@paskal paskal requested a review from akellbl4 July 27, 2022 22:23
@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 2.02 KB (0%)
public/remark.mjs 72.37 KB (0%)
public/remark.css 8.2 KB (0%)
public/last-comments.mjs 35.51 KB (0%)
public/last-comments.css 3.79 KB (-0.03% 🔽)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1448 (dde24c4) into master (5db6e43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         131      131           
  Lines        2909     2909           
  Branches      743      743           
=======================================
  Hits         1691     1691           
  Misses       1087     1087           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a2bde...dde24c4. Read the comment docs.

Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@paskal paskal merged commit fc7540f into master Jul 27, 2022
@paskal paskal deleted the paskal/size-limit-only-pr branch July 27, 2022 23:34
@paskal paskal added this to the v1.10.2 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Frontend task "Check bundle size" is broken in master
3 participants